Thanks for the comments Brad and Bernd. I've incorporated them into a new webrev :

http://cr.openjdk.java.net/~coffeys/webrev.8173783.jdk9.v2/webrev/

Brad - I've tweaked your suggestion further to indicate if the default values were used.

! "Initialized [jdk.tls.namedGroups|default] list contains " +
! "no available elliptic curves. " +
! (property != null ? "(" + property + ")" : "[Default]"));

Hope to push once build & test results are back.

regards,
Sean.


On 07/02/2017 19:15, Bradford Wetmore wrote:
Nit, I don't like the wording of 196-7. You have either jdk.tls.namedGroups or if not defined, you have the default values.

In that case, this is going to print "Property defined: null"

Maybe something along the lines of:

    "Initialized [jdk.tls.namedGroups|default] list contains " +
    "no available elliptic curves." +
    (property.exists() ? " " + property : "")

where [jdk.tls.namedGroups|default] is the branch you took to arrive at the list value.

Brad


On 2/7/2017 7:25 AM, Seán Coffey wrote:
The recent JDK-8148516 enhancement causes issue for JDKs without EC
support. It's primarily an issue for JDK 6u which doesn't have SunEC but
this still needs to be fixed in all release families.

bug report : https://bugs.openjdk.java.net/browse/JDK-8173783
webrev : http://cr.openjdk.java.net/~coffeys/webrev.8173783.jdk9/webrev/

regards,
Sean.


Reply via email to