Looks fine to me.

There is no clear reason why Paths.get(uri).toFile().getParentFile() works but not File(uri).getParentFile(). Would you mind add a comment so that the code will not modified back to use File(uri) later?

Thanks,
Xuelei

On 6/6/2017 1:40 AM, Seán Coffey wrote:
ping. Can I get a review for this please ?

regards,
Sean.


On 01/06/2017 17:23, Seán Coffey wrote:
The recent JDK-8163528 fix caused a regression for JDK binaries launched with a UNC pathname. We can use the Paths class to create the required File. I managed to put a test together which should test this code path.

webrev : http://cr.openjdk.java.net/~coffeys/webrev.8181205/webrev/
JBS record : https://bugs.openjdk.java.net/browse/JDK-8181205

regards,
Sean.


Reply via email to