On 11/22/17 9:59 AM, Alan Bateman wrote:
http://cr.openjdk.java.net/~mullan/webrevs/8186535/webrev.00/
This mostly looks good.
Does the stack walker created in AppletSecurity need to be done in a
privileged block? If this is just the mouldy appletviewer tool then
ignore my comment.
Hmm. Where do you see it being called inside doPrivileged?
A minor comment is that the <code> is legacy and we've been using {@code
...} for recent changes. We changed some of these methods to use {@code
...} when we degraded them in JDK 9.
I guess you are referring to the checkMemberAccess method. Sure I can
change it to use {@code}.
Also NoAWT probably isn't the right
place to test checkMemberAccess. If the test is renamed and the
description changed then it would be okay.
Sure, the test already had everything I need so it was easier to
leverage it rather than just duplicating. I had changed the description
already. I will just rename it to something more generic, like
DepMethodsRequireAllPerm.
--Sean
