Hi Martin I'm just starting to read this patch. Two questions:
1. Is there a webpage on configDir using sql:/? 2. Your test hardcoded nssLibraryDirectory to be "/lib64". It would need to be changed to either those inclosed the repository (macOS and Windows) or in the system (others). Is there a version requirement? 3. The test contains a lot of binary data. Can you describe more clearly on which is from where? Especially key4Content and cert9Content? In fact, can they be recreated from the existing file based db inside test/jdk/sun/security/pkcs11/nss/db? If yes, the test will be much shorter. Please at least use multiple lines for the 2 keys. Thanks Max > On Nov 29, 2017, at 10:11 PM, Martin Balao <mba...@redhat.com> wrote: > > Hi, > > I'd like to propose a fix for JDK-8165996 - PKCS11 using NSS throws an error > regarding secmod.db when NSS uses sqlite [1]. > > Webrev01: > > * http://cr.openjdk.java.net/~akasko/mbalao/8165996.webrev.01/ (browse > online) > * http://cr.openjdk.java.net/~akasko/mbalao/8165996.webrev.01.zip (download) > > Kind regards, > Martin.- > > -- > [1] - https://bugs.openjdk.java.net/browse/JDK-8165996
