On 2018-04-04 10:06, Weijun Wang wrote:
Yes. 2 spaces for "logical" indentations (such as in an if statement),
and 4 spaces for broken lines.
On Apr 4, 2018, at 3:59 PM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com>
On 2018-04-04 04:19, Weijun Wang wrote:
Please take a review at
The indentation in Lib-java.security.jgss.gmk has gone wrong. The lines in the
"$(eval $(call SetupJdkLibrary" stanza should still be indented four spaces.
See the makefile style guide:
So this is for "2. If a line must be broken, use four spaces for indentation".
Please always cc build-dev when making changes to makefiles.
I'll remember it.
Like in *nix, native GSS-API bridge is turned on by setting
-Dsun.security.jgss.native=true. Please note there is no default native GSS-API
library on Windows and you need to supply your own, like this:
-Dsun.security.jgss.lib=/path/to/gssapi64.dll App ...
You can manually test the change with
p.s. You can get a gssapi64.dll from