On 7/16/2018 8:05 PM, Xuelei Fan wrote:
On 7/16/2018 10:38 AM, Adam Petcher wrote:
New webrev:
http://cr.openjdk.java.net/~apetcher/8206929/webrev.02/
PreSharedKeyExtension.java
447 if (result && !shc.isNegotiable(s.getSuite()) ||
448 !clientHello.cipherSuites.contains(s.getSuite())) {
May miss a pair of parentheses to join the "||" expression together.
- if (result && !shc.isNegotiable(s.getSuite()) ||
- !clientHello.cipherSuites.contains(s.getSuite())) {
+ if (result && (!shc.isNegotiable(s.getSuite()) ||
+ !clientHello.cipherSuites.contains(s.getSuite()))) {
Otherwise, looks fine to me.
This will be fixed in the changeset that I push. Thanks.
Thanks,
Xuelei