> On Aug 7, 2018, at 2:50 AM, Sean Mullan <sean.mul...@oracle.com> wrote:
>
> On 8/6/18 11:14 AM, Weijun Wang wrote:
>> That would be a real behavior change and I want to be safe.
>
> I'm not seeing how this would be a behavior change if it is a new option, can
> you add more details on that? If I specify -providerName, intuitively I would
> expect it would be used, at least as the first one.
Before this change when "keytool -importcert" is called, KeyStore.getInstance()
uses "-providername" but CertificateFactory.getInstance() *does not*. Now
CertificateFactory.getInstance() is using it. If it's preferred than the
default provider, then it's a behavior change.
>
>> -providername is now used by "keytool -importcert" to choose keystore
>> implementations. I am not sure if someone already using -providername for
>> this purpose might encounter any unexpected change.
>
> How does that relate to -printcert?
Not related. In this case, it's a new option.
Thanks
Max
>
> --Sean
>
>> We can rethink about this decision if there is a real world problem. Maybe a
>> single -providername is inadequate for complicated scenarios.
>> Thanks
>> Max
>>> On Aug 6, 2018, at 10:38 PM, Xuelei Fan <xuelei....@oracle.com> wrote:
>>>
>>> Maybe, the specified provider should be honored firstly?
>>>
>>> Xuelei
>>>
>>> On 8/6/2018 1:53 AM, Weijun Wang wrote:
>>>> Ping again.
>>>> Also please take a review at the CSR at
>>>> https://bugs.openjdk.java.net/browse/JDK-8208689.
>>>> Thanks
>>>> Max
>>>>> On Aug 2, 2018, at 10:28 AM, Weijun Wang <weijun.w...@oracle.com> wrote:
>>>>>
>>>>> Please take a review at
>>>>>
>>>>> http://cr.openjdk.java.net/~weijun/8201290/webrev.00/
>>>>>
>>>>> Please note I didn't use srcProviderName as suggested in the bug report.
>>>>> It was designed to be used by the "keytool -importkeystore" command only.
>>>>>
>>>>> Thanks
>>>>> Max
>>>>>
