SSLCipher.java
--------------
line 2159-2164 in the update vs line 1992-1997 in the old file.
The new code is fine, but it takes me a while to analysis the code, and
comparing with the old one. Maybe, we can use the same implementation
code for the same logic for maintenance? Just a very personal
preference. You make the final choice. If you accept it, please
consider other places that compute the nonce value.
2180 sequence);
'sn' should be used here. The 'sequence' variable may be different from
the one used for the cipher.
Otherwise, looks fine to me.
Thanks,
Xuelei
On 9/5/2018 9:51 PM, Jamil Nimeh wrote:
Hello all,
This change will add ChaCha20-Poly1305 cipher suites to our TLS 1.2 and
TLS 1.3 implementations. A few test cases had to be updated to reflect
the new suites as well.
JBS: https://bugs.openjdk.java.net/browse/JDK-8140466
CSR: https://bugs.openjdk.java.net/browse/JDK-8204192
Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8140466/webrev.01/
Thanks,
--Jamil
