On 2018/9/27 11:20, Weijun Wang wrote:
On Sep 27, 2018, at 11:18 AM, [email protected] wrote:
On 2018/9/27 10:34, Weijun Wang wrote:
Hi John
1. Please add @bug to all tests.
Which issue should be linked? JDK-8209546?
I suppose @bug should indicate a product issue here.
At least, JDK-8209546 looks have no much association with this test.
I meant JDK-8209546. My understanding is that even if it's a noreg-self change,
the bug id should also be included.
In practice, we may not add a direct associated test bug id to the test
itself;
otherwise, many tests would contain a lot of bug ids.
In fact, we can find the test bug id in the changeset message.
In addition, the below statement is copied from jtreg FAQ item 4.28 [1]
"If you're updating a test because it was affected by a bug fix,
but the test is not otherwise a regression test for the bug fix,
then you should probably not update the @bug entry."
With my understanding, in my case, this @bug should not be updated.
[1]
http://openjdk.java.net/jtreg/faq.html#when-should-i-update-the-bug-entry-in-a-test-description
Best regards,
Best regards,
