The links from source to "DOM Mechanism Requirements" use 
"package-summary.html#dom_reqs", but the id in dsig/package-info.java is 
"dom_req".

In the sections you copied from the JSR 105 spec, some class/method names have 
links to the API spec pages, some only formatted as fixed-width texts (even if 
first appeared). Is this intended?

Otherwise looks fine.

Thanks
Max


> On Oct 16, 2018, at 1:59 AM, Sean Mullan <sean.mul...@oracle.com> wrote:
> 
> Please review this change to copy the normative parts of the Java XML Digital 
> Signature API Specification into the java.xml.crypto module javadocs and 
> update relevant links in the javadocs. The Java XML Digital Signature API 
> Specification was published as part of JSR 105 and was previously included in 
> the JDK Security Guides but as of JDK 10 had been removed and is no longer 
> maintained.
> 
> Also as part of this change, I moved all of the package.html files in this 
> module to the newer package-info.java format.
> 
> webrev:http://cr.openjdk.java.net/~mullan/webrevs/8210448/webrev.00/
> CSR: https://bugs.openjdk.java.net/browse/JDK-8212188
> 
> --Sean
> 

Reply via email to