Thanks for the review~

Valerie


On 11/5/2018 4:30 PM, Weijun Wang wrote:
Hi Valerie

The change looks fine to me.

Thanks
Max

On Nov 6, 2018, at 6:26 AM, Valerie Peng <valerie.p...@oracle.com> wrote:

Webrev updated at: http://cr.openjdk.java.net/~valeriep/8211049/webrev.01

Thanks,

Valerie


On 11/5/2018 11:52 AM, Valerie Peng wrote:
Sure, I did test only against SunRsaSign provider in my initial version if 
that's what you prefer.

Valerie


On 11/1/2018 7:55 PM, Weijun Wang wrote:
Hi Valerie

Since you are specifically fixing a bug inside the SunRsaSign provider, is it 
enough to just use the KeyPairGenerator from this provider?

The src fix is fine.

Thanks
Max


On Nov 2, 2018, at 10:14 AM, Valerie Peng <valerie.p...@oracle.com> wrote:

Hi,

Anyone can help review this trivial fix?

Bug: https://bugs.openjdk.java.net/browse/JDK-8211049

Webrev: http://cr.openjdk.java.net/~valeriep/8211049/webrev.00/

Mach5 result with the new regression test is clean.

Thanks,
Valerie

Reply via email to