On 07/11/18 13:12, Lars Francke wrote:
Seán,
thank you!
I've already sent the OCA and am in the process of getting it filed.
According to the docs[0] the next step would be to provide a patch to
this mailing list.
I have to admit that I'm a bit overwhelmed still (having never built
OpenJDK myself) so it'll take a while.
Would this patch also require a test?
you might get away without a test and add the noreg-trivial to the
eventual bug report. However, it might be no harm to examine the current
test code to see if the debug flag is exercised. If it is, it might be
the case of a simple edit to an existing test.
regards,
Sean.
Assuming it's just of the form
if (debug) {
System.out.println(...);;
}
Cheers,
Lars
<https://openjdk.java.net/contribute/>
On Wed, Nov 7, 2018 at 1:44 PM Seán Coffey <sean.cof...@oracle.com
<mailto:sean.cof...@oracle.com>> wrote:
Looks like a reasonable minor enhancement to me.
To contribute, you'll need to sign the OCA first. More information
at :
https://openjdk.java.net/contribute/
Regards,
Sean.
On 07/11/18 11:40, Lars Francke wrote:
> Hi,
>
> I have to preface this by saying that this would be my first
> contribution to OpenJDK and I'm still learning the ways. Not
sure for
> example if this is the correct mailing list or if a more generic
JDK
> one would be appropriate.
>
> While working on Hadoop based systems I frequently need to debug
> Kerberos related issues. And while there are
sun.security.krb5.debug
> and sun.security.spnego.debug the error messages could be more
helpful
> at times.
>
> One of these instance
> is sun.security.krb5.internal.ktab.Keytab#readServiceKeys.
>
> It logs that it's looking for keys but (at least for me) it
would be
> very helpful if it also logged how many keys it found after the
for-loop.
>
> If it finds keys it also logs them but if it can't find any then
> there's no message so it's easy to miss.
>
> What do you think?
>
> Cheers,
> Lars
