On 11/26/18 4:14 PM, Xue-Lei Fan wrote:
Hi,

Please review this code cleanup in SSLCipher.java:
    http://cr.openjdk.java.net/~xuelei/8214321/webrev.00/

The code should be fine as readCipherGenerators.length and writeCipherGenerators.length are the same value in the implementation. However, it is misleading to use readCipherGenerators when it is intended to use writeCipherGenerators.  It's nice to have a code cleanup for readability.

Thanks,
Xuelei

looks fine.. you'll probably want to put noreg-trivial on the bug

Tony

Reply via email to