On 11/26/18 8:30 PM, Weijun Wang wrote:
Ping

On Nov 21, 2018, at 9:56 PM, Weijun Wang <[email protected]> wrote:

Please take a review at

  https://cr.openjdk.java.net/~weijun/8214179/webrev.00/

Before this change, `keytool -genkeypair -keyalg EC -groupname brainpoolP256r1` 
shows

  Generating -1 bit EC key pair and self-signed certificate...

With this change, the message becomes

  Generating brainpoolP256r1 EC key pair and self-signed certificate...

For the above, I would prefer to also see the size of the key, like in the message below, ex:

Generating 256-bit EC (brainpoolP256r1) key pair and self-signed certificate...


Also, `keytool -list -v` can show

  Subject Public Key Algorithm: 256-bit EC(brainpoolP256r1) key

I would put a space between "EC" and "(".

--Sean


Thanks
Max


Reply via email to