On 12/7/2018 1:12 AM, Anthony Scarpino wrote:
I don't have any code comments to add to your code. It's pretty clean
and mostly algorithm code which the known answer tests will do a
better job of judging correctness.
One comment I did have was if there were any implications from using
little endian on sparcv9? This code will never interact with the
native ECC code on big endian processors? Did you/can you run sparcv9
regressions tests?
I wouldn't expect any byte order issues, since there is no interaction
with native code, direct byte buffers, etc. I ran regression tests
(including ECC KATs) on sparcv9, and I didn't get any failures. This new
implementation is not used by default on Solaris due to the provider
order---I changed the provider order during this test to make sure I was
actually testing the SunEC implementation.
Tony
