Hi Max,
On 12/13/2018 10:35 AM, Weijun Wang wrote:
Hi Roger,
I didn't run "make docs-javadoc" but I have a script that directly call the
javadoc command. While the comment still exists in the output HTML, it is still a
comment, and therefore invisible on the page.
True, but the comments are still leftovers from some previous process
and here's a chance to clean it up.
Can {@link} be used to link to a URL? I only know about using it to link to
class and method names.
ok as is, @link is only within the javadoc.
Thanks, Roger
Thanks,
Max
On Dec 13, 2018, at 10:33 PM, Roger Riggs <roger.ri...@oracle.com> wrote:
Hi,
Thanks for converting the package doc.
There is XML commented text in the package-info.java that should be removed.
It would show up in the javadoc.
And there are <a href=..> links that can now use {@link}.
It probably worth % make docs-javadoc and checking the result in
images/docs/api.
Thanks, Roger
p.s.
Documentation and test issues p1-p5, can be fixed after RPD1.
[1] https://openjdk.java.net/jeps/3
On 12/12/2018 10:59 PM, Xuelei Fan wrote:
Looks fine to me.
Xuelei
On Dec 12, 2018, at 6:25 PM, Weijun Wang <weijun.w...@oracle.com> wrote:
Ping again.
This is an RFE so needs to be fixed today unless we request for an approval.
Thanks,
Max
On Dec 7, 2018, at 11:21 PM, Weijun Wang <weijun.w...@oracle.com> wrote:
Please take a review at
https://cr.openjdk.java.net/~weijun/8214568/webrev.00
Thanks
Max
