On 1/15/19 11:20 AM, Sean Mullan wrote:
On 1/15/19 10:24 AM, Martin Balao wrote:
Hi,
Can I have a review for "JDK-8217088 - Disable JDK-6913047 fix
(SunPKCS11 memory leak) after JDK-8216597 (SIGBUS error in
getNativeKeyInfo)" [0]?
* http://cr.openjdk.java.net/~mbalao/webrevs/8217088/8217088.webrev.00/
This looks fine. Please add an appropriate noreg label to the bug since
there is no regression test.
Just "noreg" is not specific enough. You need to add one of the
noreg-<reason> labels as documented in the JDK Developer's Guide [1]
(see step 6). This is kind of a unique case, so I would add noreg-other
and then add a comment explaining that existing tests passing on Solaris
Sparc ensure that this workaround is working.
I'd be grateful if someone can run Solaris/SPARC-64 SunPKCS11 tests with
this fix applied to make sure they pass. I don't have a proper
environment to do it myself.
Ok, I'll get back to you on that in a little while.
Sorry for the delay. The tests finished. It looks good. There was one
failure in tools/launcher/Test7029048.java, but this is a known issue:
https://bugs.openjdk.java.net/browse/JDK-8216532
So you should be good to push.
Thanks,
Sean
[1] http://openjdk.java.net/guide/changePlanning.html#bug
--Sean
Thanks,
Martin.-
--
[0] - https://bugs.openjdk.java.net/browse/JDK-8217088
