Please add a noreg-self label to the bug since it is a test only fix.

--Sean

On 3/19/19 11:51 AM, Xuelei Fan wrote:
Hi Martin,

In TestTLS12.java, would you mind add a comment about why "RSASSA-PSS" should be disabled in the test case?  It may help for further update if RSASSA-PSS get supported in the SunPKCS11 provider in the future.

Otherwise, looks fine to me.

Thanks,
Xuelei

On 3/16/2019 12:52 PM, Martin Balao wrote:
Hi,

Can I have a review for JDK-8220753 [1]?

  * http://cr.openjdk.java.net/~mbalao/webrevs/8220753/8220753.webrev.00/

The test is almost identical to the previous one [2], with a few changes
in the "initialize" function (so it does not depend on the removed
SunJSSE FIPS feature anymore).

Thanks,
Martin.-

--
[1] - https://bugs.openjdk.java.net/browse/JDK-8220753
[2] -
http://hg.openjdk.java.net/jdk/jdk/file/bccd9966f1ed/test/jdk/sun/security/pkcs11/fips/TestTLS12.java

Reply via email to