Hi Xuelei,
Looks good to me.
SSLContext.java
72 throw new InternalError(e);
Why not `new ExceptionInInitializerError(e)` ?
SSLSocketImpl.java:
In `duplexCloseOutput()` I wonder if you should nest two
`try { } finally { }` statements to make really sure that the lock
is actually released. I mean is there a risk that something
like `super.shutdownOutput()` might throw?
In which case something like:
lock()
try {
try {
// do some stuff
} finally {
// do more stuff
}
} finally {
unlock();
}
might make it more clearly right.
No real need for new review if you decide to fix these...
cheers,
-- daniel
On 04/04/2019 22:32, Xuelei Fan wrote:
Hi Daniel & Alan,
All good catches! I updated accordingly:
http://cr.openjdk.java.net/~xuelei/8221882/webrev.03/
