213-217:
Previously, the set/get of both verificationResults and
verifyingProviders are synchronized. With this update, the get of
verificationResults is not out of the set synchronized block, so there
is a competition introduced. I think it would be nice to double check
the verificationResults in the synchronized block.
synchronized (JceSecurity.class) {
+ // double check if the provider has been verified
...
}
I did not get the idea to use verifyingProviders. In line 219, a
provider was inserted into the map, and in the final block, line 235,
the provider was removed from the map. There is no other update of the
map, so the map should always be empty and not really used. Am I
missing something? Could the verifyingProviders field get removed?
406-426:
I may add a blank line between two different blocks (methods, field and
methods).
- 416 if (o instanceof IdentityWrapper == false) {
+ 416 if (!(o instanceof IdentityWrapper)) {
I prefer to use "!" operator.
Xuelei
On 4/15/2019 6:20 PM, Valerie Peng wrote:
Anyone has time to review this performance rfe? The fix is based on
Sergey's suggested patch.
RFE: https://bugs.openjdk.java.net/browse/JDK-7107615
Webrev: http://cr.openjdk.java.net/~valeriep/7107615/webrev.00/
Mach5 run is clean.
Thanks,
Valerie
