Hi Max!
The fix looks good to me.
A couple of minor comments:
- the changes to CKeyStore.java seem unnecessary, since there is a
variant of CPrivateKey.of() accepting two handles.
- if you just add the bug number 8223003 to the @bug line of
FinalizeHalf.java, you won't need to specify noreg- label :)
I think, it makes sense to update the bug list because this test does
verify the fix.
With kind regards,
Ivan
On 4/26/19 12:22 AM, Weijun Wang wrote:
Please take a look at
https://cr.openjdk.java.net/~weijun/8223003/webrev.00/
Two errors are fixed:
1. CKey::cleanup is not implemented.
2. A re-fix of JDK-8163896 which was re-introduced by JDK-8213009.
No new test, the existing java/security/KeyPairGenerator/FinalizeHalf.java is
able to confirm #2. Unfortunately it didn't fail because of #1.
Anyone knows what kind of noreg-* I can use? I can only think of noreg-other
with a comment.
Thanks,
Max
--
With kind regards,
Ivan Gerasimov
