Hi Philipp,

I've posted your patch at

   http://cr.openjdk.java.net/~weijun/8221719/webrev.00/

Everyone please take a review.

I think it looks fine. Just one question: why do you need to create the 
Manifest in the test. Can you just create a jar without MANIFEST.MF and let 
jarsigner add it?

Thanks,
Max

> On May 1, 2019, at 10:14 PM, Philipp Kunz <[email protected]> wrote:
> 
> Hi Max and everyone,
> 
> With respect to the previous patch, parentheses moved from storeHash to 
> printCert, bug number added, and some comments added and clarified.
> 
> Regards,
> Philipp
> 
> 

Reply via email to