MainAttributesConfused.java, PreserveRawManifestEntryAndDigest.java, 
RemoveDifferentKeyAlgBlockFile.java, and SectionNameContinuedVsLineBreak.java 
fail on Windows because a JarFile object is not closed. You might want to use 
try-with-resources on them.

--Max


> On Jun 11, 2019, at 3:08 PM, Weijun Wang <weijun.w...@oracle.com> wrote:
> 
> Hi Philipp,
> 
> I'll start reviewing this code change. Since this is a P3 bug fix, we still 
> have a month's time (before RDP 2 starts on 7/18) to work on it.
> 
> Also, I've included John as a reviewer. He is the author of the 
> Compatibility.java test.
> 
> Thanks,
> Max
> 
>> On May 23, 2019, at 9:49 AM, Weijun Wang <weijun.w...@oracle.com> wrote:
>> 
>> Hi Philipp,
>> 
>> I've just uploaded your patch to
>> 
>> http://cr.openjdk.java.net/~weijun/8217375/webrev.01/
> 

Reply via email to