Thanks!  I have no more comments.

Xuelei

On 6/11/2019 4:19 PM, Bradford Wetmore wrote:
Updated webrev:

http://cr.openjdk.java.net/~wetmore/8171279/webrev.01/

Xuelei wrote:

 > ECDHClientKeyExchange.java
 > --------------------------
 > The enum builtin method valueOf(String) is used.  There is not problem
 > here. But as requires the enum name in NamedGroup is exactly the same as
 > the name defined in NamedParameterSpec.  It might be a potential risk
 > for future update of the names.

Unfortunately, all I have available is the key.getAlgorithm() and the key.getParams() String from the NamedParameterSpec at this point, so I've switched to NamedGroup.nameOf(String) which is what other places in the code do.

Reply via email to