On 7/9/2019 8:21 AM, Weijun Wang wrote:


On Jul 9, 2019, at 11:15 PM, Xuelei Fan <[email protected]> wrote:

It's interesting to use fake key generator.  The update looks fine to me.

I think, there are keytool test cases to use the real key generator for the 
coverage?

All other tests use real generators. The fake one is used here simply because 
keysize is too big.

Good, and thanks for the confirm!

As remind me that large key generation is still expensive in some circumstances.

Xuelei


Thanks,
Max


Xuelei

On 7/9/2019 7:35 AM, Weijun Wang wrote:
Ping again.
On Jul 3, 2019, at 10:20 AM, Weijun Wang <[email protected]> wrote:

Updated at https://cr.openjdk.java.net/~weijun/8227059/webrev.01. EC added.

--Max

On Jul 2, 2019, at 11:04 PM, Weijun Wang <[email protected]> wrote:

Please take a review at

  http://cr.openjdk.java.net/~weijun/8227059/webrev.00/

A fake DSA key pair generator with hardcoded keys. I haven't modified EC since 
it's quite fast.

Thanks,
Max



Reply via email to