Sure, thanks for review~
Valerie
On 7/26/2019 4:17 PM, Xuelei Fan wrote:
Looks good to me.
Just a nit:
58 "NoPadding":"PKCS5Padding");
I may use a white space before and after the "?" and ":" operators.
Xuelei
On 7/26/2019 3:07 PM, Valerie Peng wrote:
Sorry, should be for JDK 14. Fixed the subject.
Valerie
On 7/26/2019 3:05 PM, Valerie Peng wrote:
Any one can help review this? It's for updating a hotspot regression
test to use NoPadding when using AES GCM mode.
The regression test started failing after JDK8180392 "SunJCE
provider should throw exceptions for unsupported mode and padding
combinations" is integrated. Also removed some dead code in the
other regression test.
Bug: https://bugs.openjdk.java.net/browse/JDK-8228668
Webrev: http://cr.openjdk.java.net/~valeriep/8228668/webrev.00/
Thanks,
Valerie
