Hello Christoph, the change looks good to me . However I suggest to wait a day or two for more feedback , because
http://cr.openjdk.java.net/~clanger/webrevs/8204203.11u.0/test/jdk/sun/security/pkcs11/PKCS11Test.java.frames.html 889 @Artifact( 890 organization = "jpg.tests.jdk.nsslib", 891 name = "nsslib-windows_x64", 892 revision = "3.41-VS2017", 893 extension = "zip") 894 private static class WINDOWS_X64 { } 895 896 @Artifact( 897 organization = "jpg.tests.jdk.nsslib", 898 name = "nsslib-windows_x86", 899 revision = "3.41-VS2017", 900 extension = "zip") … looks like everyone executing these tests on Windows needs the VS2017 runtimes , isn’t it ? Is this really true for at least the main parties working on jdk11 ? In current 11u-dev I find : toolchain_windows.m4:28:VALID_VS_VERSIONS="2017 2013 2015 2012 2010" Best regards, Matthias From: Langer, Christoph Sent: Mittwoch, 4. September 2019 08:24 To: [email protected]<mailto:[email protected]> Cc: security-dev <[email protected]<mailto:[email protected]>> Subject: [11u] RFR: 8204203: Many pkcs11 tests failed in Provider initialization, after compiler on Windows changed Hi, please review the backport of this testfix to JDK11 updates. Bug: https://bugs.openjdk.java.net/browse/JDK-8204203 Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/251090f84412 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8204203.11u.0/ The backport differs in that sun/security/tools/keytool/NssTest.java doesn’t exist in 11u and hence the changes for it were omitted. Jtreg testing over all platforms, especially Windows, shows no regressions. Thanks Christoph
