Just a couple of minor comments:
1. For comments like this:
// Warning: Used by NativeCreds.c and nativeccache.c
I think not capitalizing "Used" would be better. Also, would "called by"
be more appropriate? Result:
// Warning: called by NativeCreds.c and nativeccache.c
2. Sometimes you end a comment with a period, and other times you don't:
// Warning: The following 4 fields are used by Unix.c.
I think removing the period reads better:
// Warning: The following 4 fields are used by Unix.c
On 8/19/19 10:35 AM, Weijun Wang wrote:
Ping again.
On Jul 26, 2019, at 11:24 PM, Weijun Wang <weijun.w...@oracle.com> wrote:
Please review the change at
http://cr.openjdk.java.net/~weijun/8228659/webrev.00/
Most of the change is new comments on internal Java methods called by native
code. I also take this chance to simply Ticket creation in nativeccache.c and
NativeCreds.c. There is no need to call `new Ticket(new DerValue(byteArray))`
which is identical to `new Ticket(byteArray)`.
I added the label noreg-doc but does not feel really comfortable. There is no
public document here. noreg-comment or noreg-clarification would be better, if
they exists. Please advise.
You have changed more than comments so noreg-doc is not appropriate. How
about noreg-cleanup?
--Sean
