On 9/26/19 3:41 PM, Roger Riggs wrote:
Sean,

I think that's the other EncryptionKey.
The one in src/java.security.jgss/share/classes/sun/security/krb5/EncryptionKey.java isn't.

Right you are! Ok, never mind about my comment.

--Sean



Roger


On 9/26/19 3:35 PM, Sean Mullan wrote:
- Krb5Context.java

1394         @SuppressWarnings("serial") // Not statically typed as Serializable
1395         private final EncryptionKey key;

EncryptionKey is Serializable (it derives from java.security.Key which is Serializable). I was wondering why we needed to suppress the warning here.

--Sean

On 9/23/19 8:15 PM, Joe Darcy wrote:
Hello,

Another module, another review request as part of making serial warnings more robust:

     JDK-8231368: Suppress warnings on non-serializable non-transient instance fields in java.security.jgss
     http://cr.openjdk.java.net/~darcy/8231368.0/

(Related earlier review https://mail.openjdk.java.net/pipermail/security-dev/2019-September/020672.html.)

In this latest review, I included a comment in KRBError.java that its writeObject method uses a different encoding scheme.

Thanks,

-Joe


Reply via email to