The fix looks good but I noticed that there is an existing test (javax/net/ssl/TLSCommon/MFLNTest.java) that tests this feature using the property name "jsse.enableMFLNExtension". That test should have failed because of the misspelled property. I think you should look into that to see why it didn't work properly - it may need some adjustment.

--Sean

On 11/8/19 12:22 PM, Xuelei Fan wrote:
Hi,

May I get the following update reviewed?
    http://cr.openjdk.java.net/~xuelei/8233621/webrev.00/

Trivial update, no new regression test.

The system property, "jsse.enableMFLNExtension", was introduced in JDK 9 (See JSSE Reference Guides).  However, the implementation code uses "jsse.enableMFLExtension" (without 'N') instead.

With this update, temporarily, if either of the two properties set to true, the extension is switch on. Note that we may remove the "jsse.enableMFLExtension" property in the future.  Please don't continue to use the misspelling property any longer.

Thanks,
Xuelei

Reply via email to