On 12/11/19 8:43 AM, Alan Bateman wrote:
On 11/12/2019 13:30, Sean Mullan wrote:
Please review this change to deprecate the OracleUcrypto JCE Provider for removal. This change is part of JEP 362 (Deprecate the Solaris and SPARC Ports) [1], which is Targeted to JDK 14.

Since this Enhancement was referenced from the JEP, I wasn't sure if a CSR was strictly necessary, but I drafted one anyway. Please review the CSR and diffs below.

CSR: https://bugs.openjdk.java.net/browse/JDK-8235432
This module doesn't export an API so I don't think the warning will ever be seen at compile-time. It's also not included in the API docs. So what you have is okay but you may find that a release note or other documentation will be needed to get the message out.

Yes, a release note will be published and the deprecation notice will be added to the OracleUcrypto section of the JDK Providers Guide.

Other idea is to add a comment to conf/security/java.security as that will be seen by those that edit the security configuration.

Good idea. I have added the following:

diff -r 9b513dbd57a3 src/java.base/share/conf/security/java.security
--- a/src/java.base/share/conf/security/java.security Wed Dec 11 14:08:20 2019 +0100 +++ b/src/java.base/share/conf/security/java.security Wed Dec 11 08:55:59 2019 -0500
@@ -61,6 +61,8 @@
 # List of providers and their preference orders (see above):
 #
 #ifdef solaris
+# Note: The OracleUcrypto provider is deprecated and subject to removal in
+# a future version of the JDK. See JEP 362 for more information.
 security.provider.tbd=OracleUcrypto
security.provider.tbd=SunPKCS11 ${java.home}/conf/security/sunpkcs11-solaris.cfg
 #endif

--Sean

Reply via email to