On 2/13/2020 8:41 PM, Weijun Wang wrote:
It cannot be final because it was modified later on line 149.

I think line 149 is in the same constructor, so it is possible to declare it as final.

That said, this variable is only used inside the constructor and I can make it 
local. Does that sound better to you?

It's a better update than using the final declaration.

Thanks,
Xuelei

Thanks,
Max

On Feb 14, 2020, at 1:24 AM, Xuelei Fan <xuelei....@oracle.com> wrote:

Do you want to declare the mutual variable as final object?  Otherwise, looks 
fine to me.

Xuelei

On 2/13/2020 7:14 AM, Weijun Wang wrote:
Correct the subject line.
On Feb 13, 2020, at 10:24 PM, Weijun Wang <weijun.w...@oracle.com> wrote:

Please take a review at

   https://cr.openjdk.java.net/~weijun/8160818/webrev.00

I haven't updated the server side to check the mutual state, for compatibility.

Thanks,
Max


Reply via email to