Hi Jamil,

Thanks for the review.  I will update the copyright year before pushing.

Xuelei

On 2/17/2020 3:30 PM, Jamil Nimeh wrote:
Looks good.  I like how this will simplify OID object generation for our internal uses.

Nits:

  * V3Certificate.java: Copyright should use 2020.
  * AvaEqualsHashCode: Copyright should use 2020.
  * OidEquals & OidFormat: 2020

--Jamil

On 2/17/2020 2:04 PM, Xuelei Fan wrote:
Hi,

Could I get the following update reviewed?
http://cr.openjdk.java.net/~xuelei/8239264/webrev.00/

For historic reason, the JDK internal ObjectIdentifier instances are used to constructed with int arrays (ObjectIdentifier(int[])).  It is not a performance and user friendly constructor.  Removing this constructor could have a more clear coding style, and better performance, by using alternative constructors.

Thanks,
Xuelei

Reply via email to