Hi Rajan,

I see you already pushed the fix, but I was going to ask you to also make this small change to PKCS11Test.java so if this happens next time the cause of the failure won't be swallowed by the test, which made it harder to diagnose:

diff -r 90c1d2c1f333 test/jdk/sun/security/pkcs11/PKCS11Test.java
--- a/test/jdk/sun/security/pkcs11/PKCS11Test.java Fri Mar 06 13:17:03 2020 -0500 +++ b/test/jdk/sun/security/pkcs11/PKCS11Test.java Mon Mar 09 08:03:47 2020 -0400
@@ -901,7 +901,7 @@
+ "please check if JIB jar is present in classpath.");
             } else {
throw new RuntimeException("Fetch artifact failed: " + clazz
-                        + "\nPlease make sure the artifact is available.");
+ + "\nPlease make sure the artifact is available.", e);
             }
         }
         Policy.setPolicy(null); // Clear the policy created by JIB if any

Perhaps you could fix that separately.

Thanks,
Sean

On 3/6/20 11:00 PM, Rajan Halade wrote:
The fetch artifact issue is fixed within infra so these tests can be removed from ProblemList now. Please review this changeset:

diff -r 7af6364e1792 test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txtFri Mar 06 18:03:09 2020 -0800
+++ b/test/jdk/ProblemList.txtFri Mar 06 19:56:26 2020 -0800
@@ -722,77 +722,6 @@
 sun/security/provider/PolicyParser/ExtDirsChange.java 8039280 generic-all  sun/security/provider/PolicyParser/PrincipalExpansionError.java 8039280 generic-all -sun/security/tools/keytool/NssTest.java                         8240686 windows-all -sun/security/pkcs11/SampleTest.java                             8240686 windows-all -sun/security/pkcs11/tls/TestPRF.java                            8240686 windows-all -sun/security/pkcs11/tls/TestPremaster.java                      8240686 windows-all -sun/security/pkcs11/tls/TestLeadingZeroesP11.java               8240686 windows-all -sun/security/pkcs11/tls/TestMasterSecret.java                   8240686 windows-all -sun/security/pkcs11/tls/TestKeyMaterial.java                    8240686 windows-all -sun/security/pkcs11/Signature/TestDSAKeyLength.java             8240686 windows-all -sun/security/pkcs11/Signature/TestRSAKeyLength.java             8240686 windows-all -sun/security/pkcs11/Signature/TestDSA2.java                     8240686 windows-all -sun/security/pkcs11/Signature/TestDSA.java                      8240686 windows-all -sun/security/pkcs11/Signature/SignatureTestPSS.java             8240686 windows-all -sun/security/pkcs11/Signature/SigInteropPSS.java                8240686 windows-all -sun/security/pkcs11/Signature/ReinitSignature.java              8240686 windows-all -sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java       8240686 windows-all -sun/security/pkcs11/Signature/InitAgainPSS.java                 8240686 windows-all -sun/security/pkcs11/Signature/ByteBuffers.java                  8240686 windows-all -sun/security/pkcs11/Serialize/SerializeProvider.java            8240686 windows-all -sun/security/pkcs11/SecureRandom/TestDeserialization.java       8240686 windows-all -sun/security/pkcs11/SecureRandom/Basic.java                     8240686 windows-all -sun/security/pkcs11/Secmod/TrustAnchors.java                    8240686 windows-all -sun/security/pkcs11/Secmod/GetPrivateKey.java                   8240686 windows-all -sun/security/pkcs11/Secmod/LoadKeystore.java                    8240686 windows-all -sun/security/pkcs11/Secmod/TestNssDbSqlite.java                 8240686 windows-all -sun/security/pkcs11/Secmod/JksSetPrivateKey.java                8240686 windows-all -sun/security/pkcs11/Secmod/Crypto.java                          8240686 windows-all -sun/security/pkcs11/Secmod/AddTrustedCert.java                  8240686 windows-all -sun/security/pkcs11/Secmod/AddPrivateKey.java                   8240686 windows-all -sun/security/pkcs11/rsa/TestSignatures.java                     8240686 windows-all -sun/security/pkcs11/rsa/TestKeyPairGenerator.java               8240686 windows-all -sun/security/pkcs11/rsa/TestKeyFactory.java                     8240686 windows-all -sun/security/pkcs11/rsa/TestCACerts.java                        8240686 windows-all -sun/security/pkcs11/rsa/KeyWrap.java                            8240686 windows-all -sun/security/pkcs11/Provider/Login.sh                           8240686 windows-all -sun/security/pkcs11/Provider/ConfigQuotedString.sh              8240686 windows-all -sun/security/pkcs11/MessageDigest/TestCloning.java              8240686 windows-all -sun/security/pkcs11/MessageDigest/ReinitDigest.java             8240686 windows-all -sun/security/pkcs11/MessageDigest/DigestKAT.java                8240686 windows-all -sun/security/pkcs11/Mac/MacKAT.java                             8240686 windows-all -sun/security/pkcs11/Mac/MacSameTest.java                        8240686 windows-all -sun/security/pkcs11/Mac/ReinitMac.java                          8240686 windows-all -sun/security/pkcs11/MessageDigest/ByteBuffers.java              8240686 windows-all -sun/security/pkcs11/KeyPairGenerator/TestDH2048.java            8240686 windows-all -sun/security/pkcs11/KeyGenerator/TestKeyGenerator.java          8240686 windows-all -sun/security/pkcs11/KeyGenerator/DESParity.java                 8240686 windows-all -sun/security/pkcs11/KeyAgreement/UnsupportedDHKeys.java         8240686 windows-all -sun/security/pkcs11/KeyAgreement/TestInterop.java               8240686 windows-all -sun/security/pkcs11/KeyAgreement/TestDH.java                    8240686 windows-all -sun/security/pkcs11/KeyAgreement/TestShort.java                 8240686 windows-all -sun/security/pkcs11/KeyAgreement/SupportedDHKeys.java           8240686 windows-all -sun/security/pkcs11/ec/TestECGenSpec.java                       8240686 windows-all -sun/security/pkcs11/ec/TestECDSA2.java                          8240686 windows-all -sun/security/pkcs11/ec/TestECDSA.java                           8240686 windows-all -sun/security/pkcs11/ec/TestECDH2.java                           8240686 windows-all -sun/security/pkcs11/ec/TestECDH.java                            8240686 windows-all -sun/security/pkcs11/ec/TestCurves.java                          8240686 windows-all -sun/security/pkcs11/ec/ReadPKCS12.java                          8240686 windows-all -sun/security/pkcs11/Cipher/TestSymmCiphers.java                 8240686 windows-all -sun/security/pkcs11/ec/ReadCertificates.java                    8240686 windows-all -sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java            8240686 windows-all -sun/security/pkcs11/Cipher/TestRSACipherWrap.java               8240686 windows-all -sun/security/pkcs11/Cipher/TestRSACipher.java                   8240686 windows-all -sun/security/pkcs11/Cipher/TestRawRSACipher.java                8240686 windows-all -sun/security/pkcs11/Cipher/TestPKCS5PaddingError.java           8240686 windows-all -sun/security/pkcs11/Cipher/TestKATForGCM.java                   8240686 windows-all -sun/security/pkcs11/Cipher/TestGCMKeyAndIvCheck.java            8240686 windows-all -sun/security/pkcs11/Cipher/TestCICOWithGCMAndAAD.java           8240686 windows-all -sun/security/pkcs11/Cipher/TestCICOWithGCM.java                 8240686 windows-all -sun/security/pkcs11/Cipher/Test4512704.java                     8240686 windows-all -sun/security/pkcs11/Cipher/ReinitCipher.java                    8240686 windows-all
-
  ############################################################################
  # jdk_sound



Thanks,
Rajan

Reply via email to