> On Mar 11, 2020, at 6:19 AM, Valerie Peng <valerie.p...@oracle.com> wrote:
>
>
> line 141: killme seems redundant?
Ah yes, thanks.
--Max
>
> Else looks ok to me.
>
> Thanks,
>
> Valerie
>
> On 3/9/2020 6:48 PM, Weijun Wang wrote:
>> A new webrev at
>>
>> http://cr.openjdk.java.net/~weijun/8239928/webrev.02/
>>
>> Instead of checking if stderr is empty I now read the exit code. Some
>> developer prints out debugging info in stderr.
>>
>> Finally, I give up fixing the test on Windows. Both dispose() and waitFor()
>> could hang forever.
>>
>> Thanks,
>> Max
>>
>>
>>> On Mar 3, 2020, at 10:35 AM, Weijun Wang <weijun.w...@oracle.com> wrote:
>>>
>>> Please take a review at
>>>
>>> https://cr.openjdk.java.net/~weijun/8239928/webrev.01/
>>>
>>> Looks like on windows-x64 there is a small probability (~.1%) that
>>> VMDisconnectEvent will not be caught (and thus no VMDisconnectedException).
>>> Fortunately, in the 2 failure cases I observed, the VMDeathEvent is still
>>> seen.
>>>
>>> Thanks,
>>> Max
>>>
