The CSR looks straightforward to me. You might mention that these
algorithms are Standard Names in the specification section, but it's
just a nit.
--Jamil
On 3/19/2020 3:50 PM, Valerie Peng wrote:
CSR: https://bugs.openjdk.java.net/browse/JDK-8241325
Please review~
Thanks!
Valerie
On 3/19/2020 12:54 PM, Valerie Peng wrote:
And CSR also.
On 3/19/2020 12:53 PM, Valerie Peng wrote:
Hi Sean,
Yes, thanks for the reminder. I will file the release note and
provider doc issue for this.
Valerie
On 3/19/2020 8:08 AM, Sean Mullan wrote:
Hi Valerie,
You should also file a CSR since these would be newly supported
algorithms in the JDK. Please also add a release note and file a
docs issue to update the JDK Providers doc with the new algorithms.
--Sean
On 3/18/20 6:57 PM, Valerie Peng wrote:
Anyone has time to help review this straight forward RFE? It's to
add SHA-3 support to Hmac.
RFE: https://bugs.openjdk.java.net/browse/JDK-8172680
Webrev: http://cr.openjdk.java.net/~valeriep/8172680/webrev.00/
Mach5 run is clean.
Thanks,
Valerie
