On 3/19/20 5:46 PM, Anthony Scarpino wrote:
On 3/19/20 12:23 PM, Sean Mullan wrote:
On 3/12/20 2:23 AM, Anthony Scarpino wrote:
Another webrev update with Max's recent comments.
https://cr.openjdk.java.net/~ascarpino/8237219/webrev.03
Also I still need a reviewer for the CSR.
For the CSR, I think the Compatibility Kind should be "Behavioral" and
the Scope "JDK".
Can you list in the Specification section the APIs that will now throw
an Exception when the native library is disabled and what that
Exception is? The code diffs, while fine to leave in, seem a bit too
raw to understand exactly what the behavior change is.
Also, I think the specification section should provide a description
of the system property, what the default value is and how the
implementation handles case sensitivity and syntax errors (does it
throw an Exception, ignore invalid values, etc).
--Sean
Updated
Thanks. I added my name as Reviewer.
--Sean
