On 3/25/20 5:42 PM, Jamil Nimeh wrote:
Hi Tony,

  * "Commonly used and time-constantly implemented curves, secp256r1,
    secp384r1, secp521r1, x25519, and x448, remain supported by SunEC" -
    time-constantly implemented sounds a bit awkward to my ear.
      o May I suggest an alternative: "The secp256r1, secp384r1,
        secp521r1, x25519, and x448 curve implementations are
        time-constant and remain supported by SunEC."  (I'm sure the
        wording could be better still).

Yeah, I've been fighting that too. I changed it up by just saying commonly used as that's more relevant.

* Why are there asterisks around -Djdk.sunec.disableNative=false? Were you trying to do some kind of markdown notation there?

I was trying to get italics. I thought it worked before but I'm probably forgotten the proper syntax.


Otherwise it looks good to me.

--Jamil

On 3/25/2020 4:44 PM, Anthony Scarpino wrote:
Please review the proposed release note for JDK-8237219, the change to disable the native curves in SunEC.

https://bugs.openjdk.java.net/browse/JDK-8241386

Thanks

Tony

Reply via email to