Thank you Max!

I've made the suggested adjustment and pushed the fix.

With kind regards,

Ivan

On 4/1/20 2:59 AM, Weijun Wang wrote:
Looks fine to me.

If I have to pick one tiny problem, you can remove a blank in line 58 below to 
make the indentation more precise:

src/java.security.sasl/share/classes/javax/security/sasl/SaslServer.java:

   57  *             status = ldap.sendBindResponse(mechanism, challenge,
   58  *                  SASL_BIND_IN_PROGRESS);

Thanks,
Max


On Mar 31, 2020, at 5:39 AM, Ivan Gerasimov <ivan.gerasi...@oracle.com> wrote:

Hello!

The fix follows up on JDK-8241727 [1].

This is a javadoc/comments only fix in the security-libs area.

The changes are to remove redundant empty lines, correct indentation, or 
otherwise restore harmony.

Would you please help review this rather technical fix?

BUGURL: https://bugs.openjdk.java.net/browse/JDK-8241761
WEBREV: http://cr.openjdk.java.net/~igerasim/8241761/00/webrev/

Thank in advance!

[1] https://bugs.openjdk.java.net/browse/JDK-8241727

--
With kind regards,
Ivan Gerasimov

--
With kind regards,
Ivan Gerasimov

Reply via email to