Hi Max,
Thanks for your comments!
Please review the updated webrev:
http://cr.openjdk.java.net/~jjiang/8244683/webrev.02/
The codes are refactored significantly.
On 2020/5/11 10:51, Weijun Wang wrote:
Can you update the existing TimeStampCheck test to use this class? I know that
test can simulate some error conditions. Maybe you can add one or more virtual
methods in this class so TimeStampCheck can override them.
This test is updated to use this TSA server.
A new introduced class, namely TsaInterceptor, defines some extension
points for the signing.
getDefaultSigAlgo(): Please call AlgorithmId.getDefaultSigAlgForKey() instead.
It will be enhanced to support new algorithm.
Fixed.
Param: How about making it a JDK 14 record?
In the updated webrev, this class has changed to TsaParam.
The fields are not final, and especially this class could be extended by
tests.
With my understanding, this language feature may not be applicable for
this scenario .
Best regards,
John Jiang
Thanks,
Max
On May 11, 2020, at 9:28 AM,sha.ji...@oracle.com wrote:
Hi,
This patch introduces a TSA server, which can work with jarsigner.
This server will be used by the following jar signing tests.
Issue:https://bugs.openjdk.java.net/browse/JDK-8244683
Webrev:http://cr.openjdk.java.net/~jjiang/8244683/webrev.00/
Best regards,
John Jiang
