Looks good to me.

Thanks,
Rajan

> On Jun 8, 2020, at 4:34 AM, shivangi.g.gu...@oracle.com wrote:
> 
> Thanks Rajan. I changed the webrev and ran Mach5 too. Here is the new webrev 
> link: -
> 
> http://cr.openjdk.java.net/~sshivang/reviews/8246330/webrev.01/ 
> <http://cr.openjdk.java.net/~sshivang/reviews/8246330/webrev.01/>
> 
> Thanks
> 
> Shivangi
> 
> 
> 
> On 06/06/20 7:37 am, Rajan Halade wrote:
>> One minor comment -
>> 
>> Can you please put try-catch around "(new DisabledCurve()).run();” instead 
>> of over for loop?
>> 
>> Otherwise test looks good.
>> 
>> Thanks,
>> Rajan
>> 
>>> On Jun 4, 2020, at 8:41 PM, shivangi.g.gu...@oracle.com 
>>> <mailto:shivangi.g.gu...@oracle.com> wrote:
>>> 
>>> Corrected the links.
>>> 
>>> On 04/06/20 10:59 pm, shivangi.g.gu...@oracle.com 
>>> <mailto:shivangi.g.gu...@oracle.com> wrote:
>>>> Hi, 
>>>> 
>>>> May I please find a sponsor for this patch? 
>>>> 
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8246330 
>>>> <https://bugs.openjdk.java.net/browse/JDK-8246330> 
>>>> 
>>>> Description:Many of EC named curves has been disabled with security 
>>>> property "jdk.disabled.namedCurves". The purpose of this Test is to verify 
>>>> the behavior of any EC named curve from the disabled list. 
>>>> This Test will address a single name from the disabled list as sect283r1.  
>>>>       
>>>> 
>>>> 
>>>> Webrev: http://cr.openjdk.java.net/~sshivang/reviews/8246330/webrev.00/ 
>>>> <http://cr.openjdk.java.net/~sshivang/reviews/8246330/webrev.00/>
>>>> The patch has been tested on mach5, and the individual test was passed. 
>>>> 
>>>> Thanks 
>>>> 
>>>> Shivangi
>>>> 
>> 

Reply via email to