On Tue, 29 Sep 2020 14:49:49 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Can you post an example output of that cert? What about indefinite length? >> (Ex: 0x24, (byte) 0x80, 4, 2, 'a', 'b', 4, >> 2, 'c', 'd', 0, 0) > > For your example the output is: > 0000: 24 80 ; UNIVERSAL CONSTRUCTED > OCTET STRING [INDEFINITE] > 0002: 04 02 61 62 ; OCTET STRING [2] > 'ab' > 0006: 04 02 63 64 ; OCTET STRING [2] 'cd' > 000a: 00 00 ; END-OF-CONTENT ``` > > It seems to have lost an indent, I'll take a look at that. Also in that last example, it seems to suggest that the second octet string is nested within the first one since it sits at a second indent layer. They are both primitives completely covered by their two byte values so shouldn't they sit at the same indentation level? Or is the indentation not there to suggest nested substructures and is more for separation between elements? Or is this what you mean by "lost an indent"? Also, should the end of content be at the same indentation level as the initial indefinite length encoding? ------------- PR: https://git.openjdk.java.net/jdk/pull/268
