On Tue, 29 Sep 2020 15:20:24 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> This code change rewrites DerValue into a mostly immutable class and >> simplifies DerInputStream as a wrapper for a >> series of DerValues objects. DerInputBuffer is removed. >> All existing methods of DerValue and DerInputStream should still work with >> the exact same behavior, except for a few >> places where bugs are fixed. For example, Indefinite length must be used >> with a constructed tag. >> Except for the ObjectIdentifier class where DerInputBuffer is directly >> referenced, no other code is touched. > > Weijun Wang has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev > excludes the unrelated changes brought in by the merge/rebase. The pull > request contains four additional commits since > the last revision: > - 8249783: Simplify DerValue and DerInputStream > - Merge remote-tracking branch 'origin/master' into 8249783 > - Enhance DerValue::getOctetString to be able to read multi-level > constructed value. > - 8249783: Simplify DerValue and DerInputStream Updated webrev looks fine. Only a minor nit regarding a comment remaining. ------------- Marked as reviewed by valeriep (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/232
