On Fri, 9 Oct 2020 03:58:38 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Xuelei comments > > src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java > line 621: > >> 619: null : ByteBuffer.wrap(ibuffer.toByteArray()), src, >> dst); >> 620: dst.reset(); >> 621: ghashAllToS.doLastBlock(dst, processed); > > Are we sure about using "processed" here? I'd expect the value is the number > of bytes written into dst in the > doLastBlock(...) call on line 618. Is the "processed" variable used > differently in ByteBuffer case? it should probably be 'len' ------------- PR: https://git.openjdk.java.net/jdk/pull/411
