On Wed, 21 Oct 2020 02:48:35 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Could someone please help review this RFE? Update existing RSA key pair >> generation code following the guidelines from >> FIPS 186-4 and FIPS 186-5 (draft). Current proposed changes updates the >> prime generation code (for P, Q) based on FIPS >> 186-4 B.3.3 when keysize and public exponent met the requirements set in >> FIPS 186-4/5. Thanks, >> Valerie > > Valerie Peng has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev > excludes the unrelated changes brought in by the merge/rebase. The pull > request contains four additional commits since > the last revision: > - Merge > - Updated to address review comments > - Merge branch 'master' into JDK-8199697 > - 8199697: FIPS 186-4 RSA Key Generation > > Changed RSA key pair generation code following the guidelines from FIPS > 186-4. Looks good to me. ------------- Marked as reviewed by xuelei (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/420