On Wed, 11 Nov 2020 14:36:07 GMT, Christoph Langer <clan...@openjdk.org> wrote:
> Working on 11u backports of JDK-8218021 and JDK-8250968, I found some minor > points for improvement in tests > test/jdk/sun/security/tools/jarsigner/PosixPermissionsTest.java and > test/jdk/sun/security/tools/jarsigner/SymLinkTest.java > > The details > > PosixPermissionsTest: > - it can run on any system, no matter if the default filesystem supports > Posix or not since Posix support is only required for the zipfs which is > always true. > - improve some comments for the test flow > > SymLinkTest: > - make output of createByteArray prettier > - improve inline comments to ease understanding > - add an option to main for generating ZIPBYTES > - use "Files.write(Path.of(ZIPFILENAME), ZIPBYTES)" for creating the test > zipfile This pull request has now been integrated. Changeset: 1e9a432d Author: Christoph Langer <clan...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/1e9a432d Stats: 91 lines in 2 files changed: 34 ins; 7 del; 50 mod 8256202: Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest Reviewed-by: mbaesken ------------- PR: https://git.openjdk.java.net/jdk/pull/1166
