On Mon, 16 Nov 2020 08:14:00 GMT, Sean Coffey <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> make PSSParameterSpec one line
>>
>> only in patch2:
>> unchanged:
>
> src/java.base/share/classes/java/security/spec/MGF1ParameterSpec.java line
> 168:
>
>> 166: @Override
>> 167: public String toString() {
>> 168: return "MGF1:" + mdName;
>
> do you want to insert a space after ':' ?
The current MGF part shows `MGF: MGF1:SHA-256`. An extra space would looks a
little strange, and you don't know if the key is `MGF: MGF1` or ``MGF`. I'd
rather keep the current output.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1208
