On Wed, 2 Dec 2020 18:06:33 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> I only used "!" for consistency with existing usage in P11Key.java:1080. >> Is there a reason to avoid "!" other than maybe readability? > > Save a operation could get a little bit performance. Comparing to "if (!a)", > "if (a)" is easier to read to me, and save me a cycle to compute the "!". > Anyway, not a big concern of mine, you can leave it as is if you prefer the > "if (!a)" style. Just to finish up the thought. The assembly instructions are the same using if(!a) or if(a). The difference would be how the code is setup during compile time and I believe that would be the same speed as well.. ------------- PR: https://git.openjdk.java.net/jdk/pull/1568
