On Tue, 8 Dec 2020 18:08:38 GMT, Xue-Lei Andrew Fan <[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated with implSpec tag
>
> src/java.base/share/classes/java/security/KeyStoreSpi.java line 319:
>
>> 317: * @throws CertificateException if any of the certificates
>> included in
>> 318: * the keystore data could not be stored
>> 319: * @throws UnsupportedOperationException if this method is not
>> supported
>
> We might be able to get it more clear about the behavior. For example,
> adding an implSpec tag, like:
> * @implSpec The default implementation throws
> * an {@link UnsupportedOperationException}.
> ...
> * @throws UnsupportedOperationException if the implementation
> * has not overridden this method
tag implSpec added. Thanks for the review.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1701