On Fri, 15 Jan 2021 11:24:49 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> We have a couple of calls to getpwuid_r in the codebase, like > g= getpwuid_r(getuid(), &resbuf, pwd_buf, sizeof(pwd_buf), &pwd); > > Usually we NULL-check pwd after the call because we do not fully trust the > return code of the function (it is documented in the codebase why we do not > fully trust the return code) . However we miss to initialize pwd at some > places before the call, which might we a little problematic and should be > improved (at other places we already initialize it). > > This triggers also Sonar warnings like : > https://sonarcloud.io/project/issues?id=jdk&open=AXaE0dsA8L9hkQskGEbA&resolved=false&types=BUG > > > Aside from this issue , should we in other issue , unify the OS versions of > static char* get_user_name(uid_t uid) in posix code (currently we have it > for bsd, linux, aix but the functions look very similar ? Hi Matthias, These changes look good, but could you hold off on making these changes until pull request https://github.com/openjdk/jdk/pull/2037, which consolidates the perfMemory_{aix,bsd,linux].cpp files into one perfMemory_posix.cpp file, has been integrated? Thanks, Harold ------------- PR: https://git.openjdk.java.net/jdk/pull/2098
